Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CI/CD #1

Merged
merged 3 commits into from
Dec 7, 2022
Merged

Refactor CI/CD #1

merged 3 commits into from
Dec 7, 2022

Conversation

tofran
Copy link
Member

@tofran tofran commented Dec 7, 2022

No description provided.

@tofran tofran requested a review from pdrbrnd December 7, 2022 11:30
@tofran tofran self-assigned this Dec 7, 2022
@tofran tofran force-pushed the ci-cd/refactored-package-publishing branch from 5520e24 to d239cf7 Compare December 7, 2022 11:31
@tofran tofran marked this pull request as draft December 7, 2022 15:03
@tofran
Copy link
Member Author

tofran commented Dec 7, 2022

Very interesting problem. The lockfile also saves the registry

"node_modules/@significa/prettier-config": {
      "version": "2.0.0",
      "resolved": "https://npm.pkg.github.com/download/@significa/prettier-config/2.0.0/0955fb6570fad577d3421859dceccc2da41d6788",
      "integrity": "sha512-A+zZlXhUYK1cpAOnMLtXI0W4Kp5iw/GdcwzuDoFMUsnoJ6e2DM67iEONvW2bRZy/OC6wWny0XfLvsM7JiVaJbQ==",
      "dev": true,
      "license": "MIT",
      "dependencies": {
        "prettier": "2.3.2"
      }
    },

Thus it is failing to pull

I will fix this asap @pdrbrnd

@tofran tofran force-pushed the ci-cd/refactored-package-publishing branch from 1959b1c to cb34771 Compare December 7, 2022 15:18
@tofran tofran marked this pull request as ready for review December 7, 2022 15:32
@tofran
Copy link
Member Author

tofran commented Dec 7, 2022

@pdrbrnd ready for review

@tofran tofran merged commit 038446d into main Dec 7, 2022
@tofran tofran deleted the ci-cd/refactored-package-publishing branch December 7, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdrbrnd pdrbrnd Awaiting requested review from pdrbrnd

Assignees

@tofran tofran

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tofran